Association History Processing (Part 2) #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
neekolas
changed the title
neekolas
changed the title
neekolas
force-pushed
the
04-04-association_history_processing_pt._2
branch
7 times, most recently
from
7c48f72 to
1068a6b
Compare
37ng
reviewed
Apr 5, 2024
insipx
approved these changes
Apr 5, 2024
| } | ||
|
|
||
| #[derive(Clone, Debug, PartialEq)] | ||
| pub enum SignatureKind { |
There was a problem hiding this comment.
does it make sense to handle an Other(String) kind?
For instance, in the case that someone wants to implement their custom signature type, or would that break too many assumptions?
| pub struct CreateInbox { | ||
| pub nonce: u64, | ||
| pub account_address: String, | ||
| pub initial_address_signature: Box<dyn Signature>, |
There was a problem hiding this comment.
Are we boxing all these Signatures to make it easier for ffi?
There was a problem hiding this comment.
Mostly out of expedience, although I think it does make FFI easier.
If we can come up with an unboxed solution that works everywhere I'm all for it.
Base automatically changed from
04-04-association_history_processing_pt._1
to
main
April 6, 2024 00:03
neekolas
force-pushed
the
04-04-association_history_processing_pt._2
branch
from
1068a6b to
095ddb7
Compare
This was referenced Apr 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO